X-Git-Url: http://average.org/gitweb/?a=blobdiff_plain;f=gps303%2Fstorage.py;h=c0fc89be0ad3d41029faacbce17be5c76cafd207;hb=18eda7307e92eeee6a9e2fdd2e810f98d25df654;hp=38ffaae863e979eb93fca5e948e516eaa497dae3;hpb=623ff0272e0344c26549bbed937d1d33b9822d18;p=loctrkd.git

diff --git a/gps303/storage.py b/gps303/storage.py
index 38ffaae..c0fc89b 100644
--- a/gps303/storage.py
+++ b/gps303/storage.py
@@ -1,5 +1,6 @@
 """ Store zmq broadcasts to sqlite """
 
+from configparser import ConfigParser
 from datetime import datetime, timezone
 from logging import getLogger
 import zmq
@@ -12,12 +13,13 @@ from .zmsg import Bcast
 log = getLogger("gps303/storage")
 
 
-def runserver(conf):
+def runserver(conf: ConfigParser) -> None:
     dbname = conf.get("storage", "dbfn")
     log.info('Using Sqlite3 database "%s"', dbname)
     initdb(dbname)
-    zctx = zmq.Context()
-    zsub = zctx.socket(zmq.SUB)
+    # Is this https://github.com/zeromq/pyzmq/issues/1627 still not fixed?!
+    zctx = zmq.Context()  # type: ignore
+    zsub = zctx.socket(zmq.SUB)  # type: ignore
     zsub.connect(conf.get("collector", "publishurl"))
     zsub.setsockopt(zmq.SUBSCRIBE, b"")
 
@@ -25,26 +27,24 @@ def runserver(conf):
         while True:
             zmsg = Bcast(zsub.recv())
             log.debug(
-                "IMEI %s from %s at %s: %s",
+                "%s IMEI %s from %s at %s: %s",
+                "I" if zmsg.is_incoming else "O",
                 zmsg.imei,
                 zmsg.peeraddr,
                 datetime.fromtimestamp(zmsg.when).astimezone(tz=timezone.utc),
                 zmsg.packet.hex(),
             )
-            if zmsg.peeraddr is not None:
-                addr, port = zmsg.peeraddr
-                peeraddr = str((str(addr), port))
-            else:
-                peeraddr = None
             stow(
-                peeraddr=peeraddr,
+                is_incoming=zmsg.is_incoming,
+                peeraddr=str(zmsg.peeraddr),
                 when=zmsg.when,
                 imei=zmsg.imei,
                 proto=proto_of_message(zmsg.packet),
                 packet=zmsg.packet,
             )
     except KeyboardInterrupt:
-        pass
+        zsub.close()
+        zctx.destroy()  # type: ignore
 
 
 if __name__.endswith("__main__"):