Update changelog for 1.94 release

[loctrkd.git] / loctrkd / beesure.py

diff --git a/loctrkd/beesure.py b/loctrkd/beesure.py
index 35682bd1028a8e0e0dcb7c7d96c356f7e1d8c8ac..f5bf4436fafb685b076c794c5c4463ecfbddf4d9 100755 (executable)
--- a/loctrkd/beesure.py
+++ b/loctrkd/beesure.py
@@ -373,7 +373,10 @@ class _LOC_DATA(BeeSurePkt):
         self.longitude = p.lon * p.eorw
 
     def rectified(self) -> Report:
-        if self.gps_valid:
+        # self.gps_valid is supposed to mean it, but it does not. Perfectly
+        # good looking coordinates, with ten satellites, still get 'V'.
+        # I suspect that in reality, 'A' means "hint data is absent".
+        if self.gps_valid or self.num_of_sats > 3:
             return CoordReport(
                 devtime=str(self.devtime),
                 battery_percentage=self.battery_percentage,
@@ -601,22 +604,28 @@ def parse_message(packet: bytes, is_incoming: bool = True) -> BeeSurePkt:
     """From a packet (without framing bytes) derive the XXX.In object"""
     toskip, vendor, imei, datalength = _framestart(packet)
     bsplits = packet[20:-1].split(b",", 1)
-    if len(bsplits) == 2:
+    try:
         proto = bsplits[0].decode("ascii")
+    except UnicodeDecodeError:
+        proto = str(bsplits[0])
+    if len(bsplits) == 2:
         rest = bsplits[1]
     else:
-        proto = ""
-        rest = bsplits[0]
+        rest = b""
     if proto in CLASSES:
         cls = CLASSES[proto].In if is_incoming else CLASSES[proto].Out
         payload = (
-            rest if cls.BINARY else rest.decode("Windows-1252").split(",")
+            # Some people encode their SSIDs in non-utf8
+            rest
+            if cls.BINARY
+            else rest.decode("Windows-1252").split(",")
         )
         try:
             return cls(vendor, imei, datalength, payload)
         except (DecodeError, ValueError, IndexError) as e:
             cause: Union[DecodeError, ValueError, IndexError] = e
     else:
+        payload = rest
         cause = ValueError(f"Proto {proto} is unknown")
     if is_incoming:
         retobj = UNKNOWN.In(vendor, imei, datalength, payload)